Fix no-else-return

app/__init__.py

@@ -89,7 +89,7 @@ def create_app(config_name):
                 account_hold_msg=messages.account_hold_message,
             )
 
-        elif (
+        if (
             rc_util.check_state(session["user"].get("username"))
             == "certification"
         ):
@@ -105,24 +105,24 @@ def create_app(config_name):
                 pre_certification_msg=messages.pre_certification_message,
                 certification_msg=messages.certification_message,
             )
-        elif rc_util.check_state(session["user"].get("username")) == "ok":
+        if rc_util.check_state(session["user"].get("username")) == "ok":
             return render_template(
                 "account/good_standing.html",
                 good_standing_msg=messages.good_standing_message,
             )
-        else:
-            return render_template(
-                "auth/SignUp.html",
-                room_id=session["uid"],
-                username=session["user"].get("username"),
-                fullname=session["user"].get("fullname"),
-                email=session["user"].get("email"),
-                referrer=session["return_url"],
-                cancel_url=app_vars.default_referrer,
-                welcome_msg=messages.welcome_message,
-                cancel_msg=messages.cancel_message,
-                error_msg=messages.error_message,
-            )
+
+        return render_template(
+            "auth/SignUp.html",
+            room_id=session["uid"],
+            username=session["user"].get("username"),
+            fullname=session["user"].get("fullname"),
+            email=session["user"].get("email"),
+            referrer=session["return_url"],
+            cancel_url=app_vars.default_referrer,
+            welcome_msg=messages.welcome_message,
+            cancel_msg=messages.cancel_message,
+            error_msg=messages.error_message,
+        )
 
     # misc page error catching
     @app.errorhandler(403)