Skip to content

ENH: Add getopt to run-mmpol and remove reliance on inherited environment variables

Matthew K Defenderfer requested to merge enh-add-getopt-to-run-mmpol into rel_v0.1.1-1

Wanted to remove the reliance on inherited environment variables from run-mmpol.sh while also adding useful help and usage messages to bring it more in line with other associates scripts. These changes clarify where variables are coming from and what exactly they are used for.

Major changes:

  • added getopt functionality allowing the user to specify the following variables in the function call:
    • outdir: parent directory for the log to be placed in
    • output-log-prefix: the prefix to add to the policy file name to specify extra metadata
    • policy-file: path to the policy file
    • device: path or name of the target of the policy
  • removed use of environment variables not explicitly set in the run-mmpol.sh script. These were also removed from the submit-pol-job script and replaced with the corresponding values to be explicitly passed
  • default policy file prefix is automatically created from the device path or name if not passed as an argument

Minor changes:

  • changed some variable names to maintain consistency with related scripts

Merge request reports